> On 2012-04-09 11:10:19, Brock Noland wrote: > > I think the change makes sense, but I am not sure if it solves the problem > > from the JIRA? From what I can tell about the error, it looks like HDFS is > > trying to add a shutdown hook after the shutdown has started.
The roller can cause the file to be closed during the process() and the stop() also closes the file. It looked like two threads are trying to close the same file simultaneously. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4681/#review6789 ----------------------------------------------------------- On 2012-04-09 06:54:55, Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4681/ > ----------------------------------------------------------- > > (Updated 2012-04-09 06:54:55) > > > Review request for Flume and Arvind Prabhakar. > > > Summary > ------- > > The sink runner's stop method first calls stop() to underlying sink and then > shuts down the PollingRunner thread. If that thread is in middle of process, > it leads to race conditions in the sink's process() and stop(). > Rather than making all sinks to handle concurrently process() and stop(), its > safer to shutdown the runner thread first and then stop the sink. > > > This addresses bug FLUME-1110. > https://issues.apache.org/jira/browse/FLUME-1110 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java e73c09b > > Diff: https://reviews.apache.org/r/4681/diff > > > Testing > ------- > > full regression test run > > > Thanks, > > Prasad > >
