[
https://issues.apache.org/jira/browse/FLUME-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249769#comment-13249769
]
[email protected] commented on FLUME-1011:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4669/
-----------------------------------------------------------
(Updated 2012-04-09 10:07:06.560520)
Review request for Flume.
Changes
-------
Addressed suggestions, added javadoc for property
Summary
-------
A rudimentary fix allowing setting a thread limit to the netty server used for
avro ipc.
A more involved solution would be to implement a custom thread pool but I don't
think that is entirely necessary
This addresses bug FLUME-1011.
https://issues.apache.org/jira/browse/FLUME-1011
Diffs (updated)
-----
flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
c5c3f2f
flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 903889d
Diff: https://reviews.apache.org/r/4669/diff
Testing
-------
Added the new setting into one of the tests to make sure it is exercised
Tests pass individually, I'm still having issues with running several of the
RPC related tests from mvn, but this was the case before adding this code.
Thanks,
Juhani
> AvroSource should have a configurable max thread count
> ------------------------------------------------------
>
> Key: FLUME-1011
> URL: https://issues.apache.org/jira/browse/FLUME-1011
> Project: Flume
> Issue Type: Improvement
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Fix For: v1.2.0
>
>
> AvroSource via NettyServer uses Executors.newCachedThreadPool() when
> accepting incoming connections, which means that there is no upper limit on
> the number of threads that can be spawned. It would be good to expose
> configurable core & max thread pool sizes and provide some sane defaults to
> avoid OutOfMemory errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
