[
https://issues.apache.org/jira/browse/FLUME-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249771#comment-13249771
]
[email protected] commented on FLUME-1011:
------------------------------------------------------
bq. On 2012-04-07 12:57:18, Will McQueen wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java,
line 125
bq. > <https://reviews.apache.org/r/4669/diff/2/?file=100629#file100629line125>
bq. >
bq. > Recommend this warning string:
bq. > AVRO source\'s \"threads\" prop must specify integer value.
bq. >
bq. > (here we're using the name of the type instead of the class name)
modified
- Juhani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4669/#review6771
-----------------------------------------------------------
On 2012-04-09 10:07:06, Juhani Connolly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4669/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-09 10:07:06)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. A rudimentary fix allowing setting a thread limit to the netty server used
for avro ipc.
bq.
bq. A more involved solution would be to implement a custom thread pool but I
don't think that is entirely necessary
bq.
bq.
bq. This addresses bug FLUME-1011.
bq. https://issues.apache.org/jira/browse/FLUME-1011
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
c5c3f2f
bq. flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
903889d
bq.
bq. Diff: https://reviews.apache.org/r/4669/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added the new setting into one of the tests to make sure it is exercised
bq.
bq. Tests pass individually, I'm still having issues with running several of
the RPC related tests from mvn, but this was the case before adding this code.
bq.
bq.
bq. Thanks,
bq.
bq. Juhani
bq.
bq.
> AvroSource should have a configurable max thread count
> ------------------------------------------------------
>
> Key: FLUME-1011
> URL: https://issues.apache.org/jira/browse/FLUME-1011
> Project: Flume
> Issue Type: Improvement
> Affects Versions: v1.0.0
> Reporter: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1011.2.patch
>
>
> AvroSource via NettyServer uses Executors.newCachedThreadPool() when
> accepting incoming connections, which means that there is no upper limit on
> the number of threads that can be spawned. It would be good to expose
> configurable core & max thread pool sizes and provide some sane defaults to
> avoid OutOfMemory errors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
