----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4622/#review7052 -----------------------------------------------------------
Looks good. Thanks for the patch! Nit: please change the name of the JIRA to something like: "support passing headers in AvroCLIClient". Right now the title doesn't match up very well with the content of the patch. trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java <https://reviews.apache.org/r/4622/#comment15647> Nit: is this valid syntax in the --help output? Shouldn't the space after the "," be removed? - Mike On 2012-04-09 09:52:21, Inder Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4622/ > ----------------------------------------------------------- > > (Updated 2012-04-09 09:52:21) > > > Review request for Flume, Arvind Prabhakar and Mike Percy. > > > Summary > ------- > > Patch to address FLUME 1096. Please review and share your thoughts. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1096. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1096 > > > Diffs > ----- > > > trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java > 1311132 > trunk/bin/flume-ng 1311132 > > Diff: https://reviews.apache.org/r/4622/diff > > > Testing > ------- > > 1. Configured flume agent to publish data in /data/flume/%D > 2. ran the avroClient to stream some data. > 3. Things looked ok. Data was available in HDFS. > > > Thanks, > > Inder > >
