> On 2012-04-20 00:42:42, Hari Shreedharan wrote: > > trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java, > > line 85 > > <https://reviews.apache.org/r/4622/diff/3/?file=101043#file101043line85> > > > > This a minor comment. Doing this would make "," a delimiter in the > > headers and would not allow a user to use a "," in the event header text. > > Maybe allow an alternate way to add headers, from a file, maybe a > > properties file or something,when the user cannot use "," as a delim. > > > > Also maybe convert the command line input into a properties by > > replacing the "," with "\n" and wrapping it in a input stream to handle > > the case of rogue spaces? > > > > You could do something like: > > > > private void parseHeaders(Properties p) //takes the properties and puts > > them into the headers > > > > and > > > > private void parseCommandLineHeaders(String hdrs){ > > hdrs.replaceAll(",", "\n"); > > //Wrap this hdrs in an InputStream,and load a properties object using > > that > > parseHeaders(Properties p); > > } > > > > > > Hari Shreedharan wrote: > Just to clarify: this was a nit,a good-to-have, not exactly necessary to > have. Also any alternate way of allowing "," etc would be ok, this was just a > suggestion. The headers I am talking about are something like > flume.root.logger=DEBUG,console(just an example)
Sure, headers coming through a property seems better. I'll re-work and re-post for review. - Inder ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4622/#review7054 ----------------------------------------------------------- On 2012-04-09 09:52:21, Inder Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4622/ > ----------------------------------------------------------- > > (Updated 2012-04-09 09:52:21) > > > Review request for Flume, Arvind Prabhakar and Mike Percy. > > > Summary > ------- > > Patch to address FLUME 1096. Please review and share your thoughts. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1096. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1096 > > > Diffs > ----- > > > trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java > 1311132 > trunk/bin/flume-ng 1311132 > > Diff: https://reviews.apache.org/r/4622/diff > > > Testing > ------- > > 1. Configured flume agent to publish data in /data/flume/%D > 2. ran the avroClient to stream some data. > 3. Things looked ok. Data was available in HDFS. > > > Thanks, > > Inder > >
