> On 2012-05-19 05:16:01, Arvind Prabhakar wrote: > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java, > > line 240 > > <https://reviews.apache.org/r/5166/diff/1/?file=109655#file109655line240> > > > > This timestamp will be 0 valued if rounding is disabled. A few test > > cases to make sure that the BucketPath is resolving the paths correctly > > would be a great help.
Ah, good catch! Thanks! Will fix it. > On 2012-05-19 05:16:01, Arvind Prabhakar wrote: > > flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java, > > line 26 > > <https://reviews.apache.org/r/5166/diff/1/?file=109656#file109656line26> > > > > A brief javadoc on what the utility functions accept and return would > > be great. Will do. > On 2012-05-19 05:16:01, Arvind Prabhakar wrote: > > flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java, > > line 60 > > <https://reviews.apache.org/r/5166/diff/1/?file=109656#file109656line60> > > > > Internally Calendar uses long timestamp, so would preferable to call > > cal.setTimeInMillis(timestamp) instead. Done! - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5166/#review7987 ----------------------------------------------------------- On 2012-05-19 02:36:22, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5166/ > ----------------------------------------------------------- > > (Updated 2012-05-19 02:36:22) > > > Review request for Flume. > > > Summary > ------- > > Created a utility that does the rounding. > > > This addresses bug FLUME-1213. > https://issues.apache.org/jira/browse/FLUME-1213 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > da80545 > > flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java > PRE-CREATION > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 8ce2bac > > Diff: https://reviews.apache.org/r/5166/diff > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Hari > >
