----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5166/#review7991 -----------------------------------------------------------
Ship it! +1 Thanks for incorporating all suggestions Hari. - Arvind On 2012-05-19 17:27:58, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5166/ > ----------------------------------------------------------- > > (Updated 2012-05-19 17:27:58) > > > Review request for Flume. > > > Summary > ------- > > Created a utility that does the rounding. > > > This addresses bug FLUME-1213. > https://issues.apache.org/jira/browse/FLUME-1213 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java > da80545 > > flume-ng-core/src/main/java/org/apache/flume/tools/TimestampRoundDownUtil.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java > PRE-CREATION > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 6d26f47 > > Diff: https://reviews.apache.org/r/5166/diff > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Hari > >
