[
https://issues.apache.org/jira/browse/FLUME-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289050#comment-13289050
]
Mike Percy commented on FLUME-1254:
-----------------------------------
Hi Arvind,
These changes look really good. Great job digging into and fixing this stuff!
Comments:
* I was going to say that caching InetSocketAddress instead of using the new
HostInfo class might be a good thing for performance. But then again it makes
sense to allow DNS to change under us... so, not caching each InetSocketAddress
instance actually a reliability improvement in that respect. Awesome.
Just a few nits:
1. RpcClientConfigurationConstants.java
* {{DEFAULT_CONNECT_TIMEOUT_MILLIS}} - maybe make it 5 seconds default? 60
seconds seems like a long time. I know this was there from before.
* {{DEFAULT_REQUEST_TIMEOUT_MILLIS}} - maybe make it 20 seconds default?
(Same as above)
2. It seems like much of the code in these classes is just parsing properties
file configuration. Would be nice if it was factored out somehow (using Context
object internally?) - maybe this should be another JIRA
3. Doesn't look like the commons-compress addition to pom.xml is used.
> RpcClient can hang when communication is broken with the source.
> ----------------------------------------------------------------
>
> Key: FLUME-1254
> URL: https://issues.apache.org/jira/browse/FLUME-1254
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: v1.2.0
>
> Attachments: FLUME-1254-2.patch, FLUME-1254-3.patch
>
>
> If the source that the client is connected to fails, the RpcClient can hang
> indefinitely. This problem also affects the AvroCLIClient and AvroSink since
> they internally use the same RpcClient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
