[
https://issues.apache.org/jira/browse/FLUME-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289087#comment-13289087
]
Arvind Prabhakar commented on FLUME-1254:
-----------------------------------------
Thanks for the review Mike.
bq. * DEFAULT_CONNECT_TIMEOUT_MILLIS - maybe make it 5 seconds default? 60
seconds seems like a long time. I know this was there from before.
done
bq. * DEFAULT_REQUEST_TIMEOUT_MILLIS - maybe make it 20 seconds default? (Same
as above)
done
bq. 2. It seems like much of the code in these classes is just parsing
properties file configuration. Would be nice if it was factored out somehow
(using Context object internally?) - maybe this should be another JIRA
The rational behind having properties based factory methods was to eventually
adopt a properties file based client configuration. So
{{RpcClientFactory.getInstance(CONFIG_FILE_NAME)}} will return a client that is
configured vi the property file {{CONFIG_FILE_NAME}}. Although it could
internally construct a Context to do {{getInteger()}} etc calls, but that would
be an implementation detail. I would much rather leave it as is for now.
bq. 3. Doesn't look like the commons-compress addition to pom.xml is used.
Removed.
> RpcClient can hang when communication is broken with the source.
> ----------------------------------------------------------------
>
> Key: FLUME-1254
> URL: https://issues.apache.org/jira/browse/FLUME-1254
> Project: Flume
> Issue Type: Bug
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: v1.2.0
>
> Attachments: FLUME-1254-2.patch, FLUME-1254-3.patch,
> FLUME-1254-4.patch
>
>
> If the source that the client is connected to fails, the RpcClient can hang
> indefinitely. This problem also affects the AvroCLIClient and AvroSink since
> they internally use the same RpcClient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
