----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5551/#review8568 -----------------------------------------------------------
/trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java <https://reviews.apache.org/r/5551/#comment18248> Good catch. I will update the code accordingly. /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java <https://reviews.apache.org/r/5551/#comment18247> Sorry - for some reason this diff got mixed up. The Preconditions check was actually removed. I will be updating the diff shortly with the feedback for previous comment incorporated soon. - Arvind Prabhakar On June 25, 2012, 5:21 p.m., Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5551/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 5:21 p.m.) > > > Review request for Flume and Brock Noland. > > > Description > ------- > > Currently the file channel log file can grow beyond the maximum size under > load due to non locking size check semantics. These semantics are good in > that they allow for higher concurrency rather than having exclusive access to > the writer thread between size check and write. Therefore the better fix is > to allow for minor size breach with warnings. > > This change modifies the code to relax the assertion that checks file size to > warning. Also, increased the log write default timeout from 3s to 10s. > > > Diffs > ----- > > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java > 1353634 > > /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 1353634 > > Diff: https://reviews.apache.org/r/5551/diff/ > > > Testing > ------- > > Ran full tests. > > > Thanks, > > Arvind Prabhakar > >
