----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5551/ -----------------------------------------------------------
(Updated June 25, 2012, 11:20 p.m.) Review request for Flume and Brock Noland. Changes ------- Incorporated review feedback. Description ------- Currently the file channel log file can grow beyond the maximum size under load due to non locking size check semantics. These semantics are good in that they allow for higher concurrency rather than having exclusive access to the writer thread between size check and write. Therefore the better fix is to allow for minor size breach with warnings. This change modifies the code to relax the assertion that checks file size to warning. Also, increased the log write default timeout from 3s to 10s. Diffs (updated) ----- /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 1353634 /trunk/flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java 1353634 /trunk/flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java 1353634 Diff: https://reviews.apache.org/r/5551/diff/ Testing ------- Ran full tests. Thanks, Arvind Prabhakar
