----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5463/ -----------------------------------------------------------
(Updated June 29, 2012, 1:23 a.m.) Review request for Flume. Changes ------- Hi, Hari I upload with new patch and it works fine with svn and git on Ubuntu 11: leslin@ubtServer:/usr/lib/flume-1.2.0-incubating-SNAPSHOT/bin$ ./flume-ng version Flume 1.2.0-incubating-SNAPSHOT Subversion https://svn.apache.org/repos/asf/incubator/flume/trunk -r 1354800 Compiled by leslin on Fri Jun 29 08:10:32 CST 2012 >From source with checksum ac1f4fc6f90b4a46a958c65265867c19 leslin@ubtServer:/usr/lib/flume-1.2.0-incubating-SNAPSHOT/bin$ ./flume-ng version Flume 1.2.0-incubating-SNAPSHOT Subversion git://ubtServer/data/flume-truck/flume -r 70e24f81f0e1a5fdb8eef57bf2242a69a2bf268e Compiled by leslin on Thu Jun 28 22:03:19 CST 2012 >From source with checksum 3cb408adc76ea18abf8cfc945c5319db For md5 on mac os or md5sum on linux, I add judge logic for it. But I don't have mac os to test. But the permission still need to change mode manually. Two ways to solve it: 1. Change it on Apache host, so all can get the file with right mode. this will be easy if this can be accepted. 2. Use assembly maven-assembly-plugin to change file permission before compile I tied with below 1)Below will not work and failed with permission error. User still have to change mode manually. <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-assembly-plugin</artifactId> <configuration> <descriptors> <descriptor> <fileSet> <directory>${basedir}/scripts</directory> <outputDirectory>${basedir}/scripts</outputDirectory> <directoryMode>0755</directoryMode> <fileMode>0755</fileMode> </fileSet> </descriptor> </descriptors> </configuration> </plugin> 2) I tried to add phase for it. but failed with message like: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.2.2:single (assemble-change-mode) on project flume-ng-core: Unable to parse configuration of mojo org.apache.maven.plugins:maven-assembly-plugin:2.2.2:single: When configuring a basic element the configuration cannot contain any child elements. Configuration element 'descriptor'. -> [Help 1] <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-assembly-plugin</artifactId> <executions> <execution> <id>assemble-change-mode</id> <phase>initialize</phase> <goals> <goal>single</goal> </goals> <inherited>false</inherited> </execution> </executions> <configuration> <descriptors> <descriptor> <fileSet> <directory>${basedir}/scripts</directory> <outputDirectory>${basedir}/scripts</outputDirectory> <directoryMode>0755</directoryMode> <fileMode>0755</fileMode> </fileSet> </descriptor> </descriptors> </configuration> </plugin> Description ------- Add feature to let flume-ng get version info: eslin@ubtServer:/usr/lib/flume-ng/bin$ flume-ng version Apache Flume version: 1.2.0-incubating-SNAPSHOT Built-By: 1.2.0-incubating-SNAPSHOT This addresses bug FLUME-1240. https://issues.apache.org/jira/browse/FLUME-1240 Diffs (updated) ----- bin/flume-ng 43d1766 flume-ng-core/pom.xml e4c8104 flume-ng-core/scripts/saveVersion.sh PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/VersionAnnotation.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/tools/VersionInfo.java PRE-CREATION flume-ng-core/src/test/java/org/apache/flume/tools/TestVersionInfo.java PRE-CREATION Diff: https://reviews.apache.org/r/5463/diff/ Testing ------- Test with: flume-ng version flume-ng agent -n agent -f /usr/lib/flume-ng/conf/flume-conf.properties Thanks, Leslin (Hong Xiang Lin)
