> On June 29, 2012, 11:49 a.m., Ralph Goers wrote: > > I am afraid I am going to have to be -1 on this fix until a) it supports > > Windows or b) FLUME-1174 is closed as wont-fix. There are people who seem > > to be actively engaged on making the build work on Windows in that issue > > and this one just makes their job harder.
Ralph, This patch makes sure the build does not fail on Windows: https://reviews.apache.org/r/5665 and this does not come in the way of people working on FLUME-1174. I hope that you will withdraw your -1. Making the same feature available on Windows will need to be taken care of by someone who is familiar with Windows batch scripting. Thanks. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5463/#review8745 ----------------------------------------------------------- On June 29, 2012, 5:50 a.m., Leslin (Hong Xiang Lin) wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5463/ > ----------------------------------------------------------- > > (Updated June 29, 2012, 5:50 a.m.) > > > Review request for Flume. > > > Description > ------- > > Add feature to let flume-ng get version info: > eslin@ubtServer:/usr/lib/flume-ng/bin$ flume-ng version > Apache Flume version: 1.2.0-incubating-SNAPSHOT > Built-By: 1.2.0-incubating-SNAPSHOT > > > This addresses bug FLUME-1240. > https://issues.apache.org/jira/browse/FLUME-1240 > > > Diffs > ----- > > bin/flume-ng 43d1766 > flume-ng-core/pom.xml e4c8104 > flume-ng-core/scripts/saveVersion.sh PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/VersionAnnotation.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/tools/VersionInfo.java > PRE-CREATION > flume-ng-core/src/test/java/org/apache/flume/tools/TestVersionInfo.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5463/diff/ > > > Testing > ------- > > Test with: > flume-ng version > flume-ng agent -n agent -f /usr/lib/flume-ng/conf/flume-conf.properties > > > Thanks, > > Leslin (Hong Xiang Lin) > >
