----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5683/#review8773 -----------------------------------------------------------
lgtm. Few comments. - Are we trying to use these two properties (connect-timeout and request-timeout) to both AvroSink and AvroRpc (using Properties to RpcClient)? Both uses RpcClientFactory with properties. I think AvroSink client.type property should honor only DEFAULT (and ignore DEFAULT_FAILOVER and DEFAULT_LOADBALANCE) flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java <https://reviews.apache.org/r/5683/#comment18546> I think we need to add connect-timeout and request-timeout javadoc here? values in milliseconds flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java <https://reviews.apache.org/r/5683/#comment18545> flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java <https://reviews.apache.org/r/5683/#comment18547> counter for failure here? will be used in metrics (for rollbacks and exceptions) flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java <https://reviews.apache.org/r/5683/#comment18548> single space needed before "ms" flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java <https://reviews.apache.org/r/5683/#comment18549> single space needed before "ms" flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java <https://reviews.apache.org/r/5683/#comment18544> If batchSize is null, can't we set it to 1 or RpcClientConfigurationConstants.DEFAULT_BATCH_SIZE. I think hostName and port are mandatory for client connection. - Mubarak Seyed On June 30, 2012, 12:36 a.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5683/ > ----------------------------------------------------------- > > (Updated June 30, 2012, 12:36 a.m.) > > > Review request for Flume. > > > Description > ------- > > Patch to add support for configurable connect and request timeout to Avro > Sink. Also refactors some of the RpcClient libs to reduce the # of codepaths. > > > This addresses bug FLUME-1316. > https://issues.apache.org/jira/browse/FLUME-1316 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 5c6d0e3 > flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java 3765924 > flume-ng-doc/sphinx/FlumeUserGuide.rst 94f951f > flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java > 606a4bd > flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java > e19b093 > flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java e4f23a6 > flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java > 77bf331 > > Diff: https://reviews.apache.org/r/5683/diff/ > > > Testing > ------- > > Added a unit test for the new params. Existing unit tests pass. > > > Thanks, > > Mike Percy > >
