-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5683/
-----------------------------------------------------------
(Updated July 3, 2012, 7:35 p.m.)
Review request for Flume.
Changes
-------
Updated patch has the following changes:
- Properly catches Throwable in the sink process() function
- Changed default connect timeout to 20 sec (same as request - connect timeout
is something of a misnomer)
- Updated Javadoc
- Addressed output spacing nits
Description
-------
Patch to add support for configurable connect and request timeout to Avro Sink.
Also refactors some of the RpcClient libs to reduce the # of codepaths.
This addresses bug FLUME-1316.
https://issues.apache.org/jira/browse/FLUME-1316
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 5c6d0e3
flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java 3765924
flume-ng-doc/sphinx/FlumeUserGuide.rst 94f951f
flume-ng-sdk/src/main/java/org/apache/flume/api/NettyAvroRpcClient.java
606a4bd
flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java
e304689
flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java e19b093
flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java e4f23a6
flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java
77bf331
Diff: https://reviews.apache.org/r/5683/diff/
Testing
-------
Added a unit test for the new params. Existing unit tests pass.
Thanks,
Mike Percy
