DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=28706>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28706 [PATCH] More justification problems ------- Additional Comments From [EMAIL PROTECTED] 2004-05-14 21:37 ------- Chris, A trailing space at the end of the last line of a paragraph is certainly a problem; it simply should not be there. While it does not cause much harm, it is better to avoid it. It does point to a slight problem in the logic of the code. The addition of the else branch remedies that problem. The word 'spaces' is there allright without the patch. The addition of the else branch has nothing to do with it. The argument refers back to patch 28314, where the word 'spaces' disappeared unless a change was applied which added bp to vecInlineBreaks. I argue that I am not completely happy with this change, and prefer to review the return value of prevCouldEndLine, such that it returns false if prev is the last item in vecInlineBreaks: if (vecInlineBreaks.get(vecInlineBreaks.size() - 1) == prev) { return false; } With this addition to prevCouldEndLine, instead of adding bp to vecInlineBreaks, the disappearance of the word 'spaces' is avoided as well. Simon
