https://issues.apache.org/bugzilla/show_bug.cgi?id=49687

--- Comment #33 from Glenn Adams <gl...@skynav.com> 2011-06-10 20:44:11 UTC ---
I believe this is a side-effect of Simon's incremental merges from trunk into
the Temp_ComplexScripts branch. I'm doing my work in my dev repo at
git://github.com/skynavga/fop.git, from which I irregularly post a new patch
for merger into Temp_ComplexScripts. I've got a couple of bugs I'm working on,
after which I expect to submit a new patch before the end of June.

Regarding CS suppressions, I expect they will remain in the source I authored
since I use somewhat different style conventions than were used by the
pre-existing code. For example, I use:

* longer lines
* a few methods with greater than 7 parameters
* slightly different spacing conventions

When I've modified pre-existing files, then I kept to the existing checkstyle
conventions; however, with some new files, I have varied a bit. I don't have
any plans to change those new files at this time. This does not affect
functionality.

G.

(In reply to comment #32)
> I just tried checking it out, and got two types of compile error when trying 
> to
> build:
> 
>     [javac] ... org/apache/fop/layoutmgr/BidiUtil.java:42: cannot find symbol
>     [javac] symbol  : class Viewport
>     [javac] location: package org.apache.fop.area.inline
>     [javac] import org.apache.fop.area.inline.Viewport;
>     [javac]                                  ^
> 
>     [javac] ... org/apache/fop/layoutmgr/BidiUtil.java:107: reference to
> collectRuns is ambiguous, both method
> collectRuns(java.util.List,java.util.List) in 
> org.apache.fop.layoutmgr.BidiUtil
> and method collectRuns(Viewport,java.util.List) in
> org.apache.fop.layoutmgr.BidiUtil match
>     [javac]         List runs = collectRuns ( la.getInlineAreas(), new 
> Vector()
> );
>     [javac]                     ^
>     ...
>     [javac] 13 errors
> 
> Replacing all references with InlineViewport fixes the problem (committed in
> rev 1134414)
> 
> First look: hope the CS suppressions aren't there to stay... ;-P
> 
> (more detailed review to follow)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to