With this latest patch, I am satisfied that there is sufficient testing and stability in the CS branch to support its merger into trunk. Therefore, I request that such a merge be accomplished after applying patch 5 to the CS branch as described below.
This newest patch primarily fills out the a thorough set of test cases for CS functionality, particularly as related to Arabic and RTL scripts. In particular, there are now approximately 562,000 test items covering: - bidi classes and algorithm - ~216,000 tests - opentype advanced typographic tables (gdef/gsub/gpos) - ~6000 tests - arabic script word forms - ~340,000 tests On my MacBook Pro (5 years old), these tests take about 43 seconds (see junit-complexscripts). Note that there remains work to be done on CS support, including adding support for: - additional scripts - additional output formats At present, support is provided for: - Arabic, Hebrew, and Devanagari Scripts - PDF output format I expect that additional support for other scripts and formats will be added over time, either by myself, or other members of the community. However, the absence of support for all complex scripts and all output formats should not be a deterrent to active use of the support already present. It is now a good time to broaden the user community of the CS features, and the best way to do that is to bring it into the trunk at this time. Regards, Glenn On Sat, Oct 15, 2011 at 6:00 PM, <bugzi...@apache.org> wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=49687 > > --- Comment #41 from Glenn Adams <gl...@skynav.com> 2011-10-15 10:00:16 > UTC --- > This patch is to be applied to revision 1183594 of branch > Temp_ComplexScripts > as follows: > > cd ${FOP}/branches/Temp_ComplexScripts > svn update -r 1183594 --force > svn revert -R . > svn status # check and remove any unexpected changes prior to patching > gzcat ${DOWNLOADS}/fop-i18n.arabic-patch-5.diff.gz | patch -p0 > ant resgen-complexscripts clean > svn add test/java/org/apache/fop/complexscripts/gsub > svn add test/java/org/apache/fop/complexscripts/gdef > svn add test/java/org/apache/fop/complexscripts/gpos > svn add > test/java/org/apache/fop/complexscripts/arabic/GenerateArabicTestData.java > svn add test/java/org/apache/fop/complexscripts/arabic/ArabicTestCase.java > svn add > test/java/org/apache/fop/complexscripts/arabic/ArabicTestConstants.java > svn add test/java/org/apache/fop/layoutengine/LayoutEngineTestUtils.java > svn add test/java/org/apache/fop/util/NumberConverterTestCase.java > svn add > > test/layoutengine/standard-testcases/region-body_column-count_1_writing-mode_rl.xml > svn add > test/layoutengine/standard-testcases/page-sequence-force-page-count-odd.xml > svn add > > test/layoutengine/standard-testcases/region-body_column-count_2_writing-mode_rl.xml > svn add test/resources/complexscripts/arab/data > svn propdel svn:mime-type > test/resources/complexscripts/arab/data/arab-001.txt > svn add src/java/org/apache/fop/util/NumberConverter.java > svn rm --force > test/java/org/apache/fop/complexscripts/arabic/ArabicScriptTestSuite.java > svn commit ... > > This patch includes the following: > > * bug fixes > * new layout engine tests for right-to-left writing mode > * new test utility for using TTX files in testing advanced typographic > tables > * new test cases for GDEF/GSUB/GPOS advanced typographic tables > * new test cases for ~85000 arabic word forms against four fonts > * new implementation of number formatter for number to string conversion, > which > adds support for arabic, hebrew, thai, and kana scripts > > See milestone "Patch 5" at http://skynav.trac.cvsdude.com/fop/report/6 for > further details. > > Regards, > Glenn > > -- > Configure bugmail: > https://issues.apache.org/bugzilla/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are the assignee for the bug. >
