Hi Jeremias, Thanks for your message. I haven't got that far on restructuring aspect yet and since you have objections, I think that sub-classing would be a workable and better option. I am aiming to do this within the next few weeks and so will post an update here on how it goes.
Regards, Robert Meyer > Date: Thu, 26 Sep 2013 12:04:53 +0200 > From: d...@jeremias-maerki.ch > To: fop-dev@xmlgraphics.apache.org > Subject: Re: Move PSGraphics2D and other shading classes from XGC to FOP > > Hi Robert > > I know I am probably too late but I'm swamped right now and haven't > followed the mailing lists that frequently in the last weeks. If it is > possible to add that functionality by subclassing PSGraphics2D inside > FOP, then I object to the move. Those classes have been moved from FOP > to XGC in the past since they have no dependency on FOP and (more > importantly) have their uses outside the context of Batik and FOP. I'm > using PSDocumentGraphics2D separately from FOP and Batik in one of my > projects. Therefore I wouldn't be happy to see that move back to FOP. > > Thanks, > Jeremias Maerki > > > On 20.09.2013 17:00:10 Robert Meyer wrote: > > Hi, > > > > I am looking to add Postscript Radial and Axial shading patterns to FOP. > > The class to change to allow this is PSGraphics2D and PSTilingPattern which > > exists in the XGC project. This wouldn't be a problem except that to modify > > the code to handle these new patterns I would need to create a reference to > > Batik from XGC. This is because Radial and Axial calls are made using Batik > > classes such as RadialGradientPaint. > > > > Having looked at the XGC code it seems that both classes to be modified are > > not needed specifically in XGC and therefore to avoid having to create a > > reference to Batik, I am planning on moving them to FOP. If you have any > > concerns with this move, please feel free to let me know. If I don't hear > > anything back on this then I'll assume lazy consensus and go ahead with the > > move. I'll post a patch a week before I apply it. > > > > Regards, > > > > Robert Meyer > > >