On 08/18/2016 03:16 PM, Ori Rabin wrote:
Hello,
The hash rocket syntax is still in use throughout the project.
New prs are sometimes submitted with the x: y syntax instead and then
asked to change.
As discussed on IRC yesterday there should be consistency and there is
an option to autofix with rubocop if the style is changed to change
existing code with less effort.
Since right now the lowest ruby version supported in core is 2.0 and
there are even discussions about dropping that, should this syntax change?
I have no strong opinion about rocket vs. json syntax and I can live
with both. I started to lean towards json style recently. There's one
thing I'm afraid of though:
the autofixing with rubocop, which will complicate cherry-picks. So I'd
say let's start writing new code with json-like hashes and slowly
iterate towards it rather then autofix the whole codebase.
Ori
--
You received this message because you are subscribed to the Google
Groups "foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to foreman-dev+unsubscr...@googlegroups.com
<mailto:foreman-dev+unsubscr...@googlegroups.com>.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
