Hello, yes, I find it annoying and I liked the jenkins job more. It would be great if hound would be able to use reviews that would generate one email per review. Hopefully they work on it. Otherwise I'd be for moving back to jenkins.
On středa 11. ledna 2017 12:07:38 CET David Davis wrote: > Not sure if it helps you but you can filter out the HoundCI emails by > checking for emails from "Hound <notificati...@github.com>”. Also, when a > HoundCI comment is addressed, isn’t the comment collapsed? Sometimes that's annoying as well, the the hound comments in collapsed thread. -- Marek > I agree though that HoundCI doesn’t seem to work properly. On Katello, > we’ve seen it add inline comments but pass PRs, fail Pos without inline > comments, and raise inline comments that we’re not seeing when running > rubocop locally. > > Another reason to move to Jenkins is that sometimes HoundCI doesn’t catch > all the errors that actually rubocop might since it only looks at the lines > changed. Like right now, it doesn’t look like rubocop is passing for > foreman on develop. > > > David > > On Wed, Jan 11, 2017 at 11:18 AM, Timo Goebel <m...@timogoebel.name> wrote: > > Hi devs, > > > > I'm usually not very easily annoyed. What get's me started though > > eventually is when things don't work properly. > > HoundCI is one of those things. > > > > My main concern is, that I get an e-mail and/or Github notification for > > every single comment. These can easily be ten or more e-mails. They're not > > grouped as other reviews. > > In addition, the inline comments are very distracting when reviewing a PR > > imho. When the issues are fixed, I'd prefer for the comments to be > > removed. > > When reviewing a PR, I usually don't care about the style issues. I just > > want to see if there are some problems or if all is fine. > > > > Back in the days, code style was checked by Jenkins. I think, it did a far > > better job in displaying style issues. With the current Jenkins Github > > plugin it believe would be easily possible to show style issues as a > > separate line along with all the other CI checks. > > > > One argument in favor of HoundCI is, that it checks JavaScript style. But > > I think, that can easily be set up in Jenkins as well by running eslint. > > > > Any comments? How do others feel? > > > > Timo > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to foreman-dev+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
