On 01/11, Timo Goebel wrote: > Hi devs, > > I'm usually not very easily annoyed. What get's me started though > eventually is when things don't work properly. > HoundCI is one of those things. > > My main concern is, that I get an e-mail and/or Github notification for > every single comment. These can easily be ten or more e-mails. They're not > grouped as other reviews. > In addition, the inline comments are very distracting when reviewing a PR > imho. When the issues are fixed, I'd prefer for the comments to be removed. > When reviewing a PR, I usually don't care about the style issues. I just > want to see if there are some problems or if all is fine. > > Back in the days, code style was checked by Jenkins. I think, it did a far > better job in displaying style issues. With the current Jenkins Github > plugin it believe would be easily possible to show style issues as a > separate line along with all the other CI checks.
I don't think it did a better job displaying the issues. I do remember having to point up people to the exact jenkins page where rubocop failures showed up, as it wasn't immediately obvious what happened. Inline comments show new contributors what's failing right there. That was my motivation for using Hound, also Javascript linting and saving us the trouble of having more jobs in jenkins was also a nice side benefit > > One argument in favor of HoundCI is, that it checks JavaScript style. But I > think, that can easily be set up in Jenkins as well by running eslint. > > Any comments? How do others feel? > > Timo > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Daniel Lobato Garcia @dLobatog blog.daniellobato.me daniellobato.me GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 Keybase: https://keybase.io/elobato -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
