I am also for keeping the change but giving more attention to the upgrades and providing some tooling to convert existing templates.
LZ On Wed, Jan 11, 2017 at 5:05 PM, Daniel Lobato Garcia <elobat...@gmail.com> wrote: > Hi foreman devs, > > Just noticed today https://github.com/theforeman/foreman/pull/3983/files > after some comments on IRC. What's the background behind this change? > > As far as I can see, this merely moves > > @host.param to host_param > @host.param_true? to host_param_true? > @host.param_false? to host_param_false? > @host.info to host_enc > > without gaining anything from the change. This will force people to > change their templates (including our community templates) when the > deprecation is removed, and there's nothing to gain. > > Does someone know what's the rationale behind this change? As it stands > right now, I propose reverting that commit entirely to avoid inflicting > that pain on users - which include many devs who maintain templates. > > Best, > > -- > Daniel Lobato Garcia > > @dLobatog > blog.daniellobato.me > daniellobato.me > > GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 > Keybase: https://keybase.io/elobato > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Later, Lukas @lzap Zapletal -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
