On 17 September 2022 21:50:20 CEST, Mikael Morin <[email protected]> wrote:
>Le 17/09/2022 à 21:33, Mikael Morin a écrit :
>> The testcase from the patch was not specifically checking lack of
>> side-effect clobbers, so I have double-checked with the following testcase,
>> which should lift your concerns.
>>
>The dump matches didn’t fail as expected with patch 2/10 reversed.
>This testcase should be better.
! { dg-final { scan-tree-dump-times "456" 0 "optimized" { target __OPTIMIZE__ }
} }
I'd spell this as scan-tree-dump-not, fwiw.
That said, plain scan-tree-dump is usually only viable in arch influenced
checks which in fortran we do not usually have. Here, we should for the most
part use -not or a specific -times.
I think you had a check for integer(kind=4) in there, too, which might not work
all that well for -fdefault-integer-8 or, for the corresponding real scan,
-fdefault-real-8, eventually. Easily tweaked on top if anyone (certainly will)
complain later on, though..
fore, either way, I'd say :-)
thanks,
