On Sun, Oct 02, 2011 at 12:33:08PM +0200, Stephan Beal wrote: > 2011/10/2 Lluís Batlle i Rossell <virik...@gmail.com> > > > As for leaks, the memory leak about annotate was at every checkin > > traversed, > > though. Does the change in that branch look fine for a merge? > > > Just to be clear - that's not the only leak in fossil. There many, many > places where resources are left to be cleaned up by exit(). Every time you > call cgi_set_content_type() or cgi_set_parameter() (e.g. to initialize the > state for a new request), it's leaking (twice in cgi_set_parameter()). > Fixing these requires not only calls to free(), but the infrastructure for > tracking the memory which eventually needs to be freed.
Well, those are exactly the kind of leaks that can be forgotten about, thanks to fork(). I just wanted to state the difference about those and the 'annotate leak'. Regards, Lluís. _______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
