Apologies for bringing this thread back up a week later -- I'm playing catch up on the list today.
On Thu, 19 Jul 2012 08:24:03 -0700, Nolan Darilek <[email protected]> wrote:
Asked this before but never got an answer, and it seems like an annoying usability issue.When I'm editing a commit, why is there both a checkbox and a text field for adding a new tag to a commit? Would it not make sense to assume that if I've typed text in the "add a new tag" box, then I intend to add that tag? If it is left blank, then I don't?There is an accessibility issue in that the form labels aren't matched with entries, primarily because there are no <label/> elements. So this screen doesn't render terribly well for screen reader users, and it is unclear whether I am canceling a tag or adding a new one. There are two solutions:1. Use <label> elements correctly throughout the UI or
I submitted a patch to do just this 6 or so months ago, though sent it directly to Richard instead of to this list (this was probably an error in judgement on my part). I've attached the patch and included some notes below, in case there's any interest.
Caution -- the patch is against [9c28bca430] which was current trunk at the time. If there's sufficient interest I'd also be glad to bring the patch up to date.
On Sat, 11 Feb 2012 00:16:01 -0800, Themba Fletcher <[email protected]> wrote:
<snip>
The attached patch (against [9c28bca430] -- current trunk as of this
email) wraps all of the checkbox and radio inputs in the web interface
with a <label> element. For example this:
<td colspan="6" align="left">
<input type="checkbox" name="pclr">
Propagate color to descendants
</td>
becomes:
<td colspan="6" align="left">
<label>
<input type="checkbox" name="pclr">
Propagate color to descendants
</label>
</td>>
It worked well across browsers when I tested it, and IIRC handled the activation of the checkbox on text field focus as well.
2. Just drop the checkbox here.While <label> everywhere would rock, I think this checkbox is redundant, so seems like removing it would be the easiest accessibility fix here.Thanks. _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
-- Themba Fletcher Description/Entity ...................... (tif@)descriptionentity.com 209-591-8096 ...................................... cell 317-435-6970
wrap.patch
Description: Binary data
_______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
