On Sat, Oct 4, 2014 at 9:22 PM, Stephan Beal <sgb...@googlemail.com> wrote:
> Management summary: fixed now: > > > http://www.fossil-scm.org/index.html/info/334d7744021dba7be0a34d88aacb32a9a4860291 > The cause was that the password prompt did not consider the 3rd failure to > be an error, > Correction: second password-prompt failure is treated as an error. @Other devs: i see one potentially unwanted side-effect of this in autosync_loop(): it will treat each client_sync()-level failure (which includes 2 password prompt attempts) as a single failure, meaning that the semantics of "number of retries" is subtly... not necessarily wrong, but possibly arguable. Each 2 password fails is counted as one error for purposes of autosync_loop(), meaning that a (set of) password prompt login error(s) will now be picked up by autosync_loop(), where that case was effectively ignored before. Before this change autosync_loop() did not consider login-prompt failure to be an error. This seems to be an unusual corner case, and i'm not sure which behaviour (old or new) is optimal for this case. If you suspect this change may have unwanted side effects on other (non-clone) client_sync()-using routines, please voice your suspicions! -- ----- stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal "Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do." -- Bigby Wolf
_______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
