On 2017-06-20 11:17, James Richters wrote:
That will be a great help. Might I suggest mentioning the existence
and use of Agg2D in agg_2D and vice versa? Something like:
Ah yes, I forgot about that. I'll add it now.
I also think you have made enough changes to it to warrant version
number changes.
After moving AggPas into the fpGUI repository, I don't consider it a
separate "project" as such - even though it can still be used
independent from fpGUI. So the original AggPas version numbering is of
no concern to me any more, it will now follow the versions of fpGUI itself.
The unit header comment does mention that I forked it from the original
2.4 RM3 AggPas, but that things diverged from there.
I'm also strongly considering renaming the "render/software/"
directory to "render/aggpas/". I'll mull this over for another day
or two.
I like the proposed directory name. I wonder if it really needs 2
directories, why not just render-aggpas/ or aggpas-render/ ?
The 2 part directory names is because other Canvas renderers will and
can be added to fpGUI. eg: Locally I already have a user contributed
Cairo canvas renderer which lives in the "render/cairo/" directory, but
has not been made public yet in the Github/SourceForge repositories.
This is also why I think I should rename the "render/software/"
directory to "render/aggpas/" - it makes things much clearer.
I'm also thinking of refactoring the X11 and GDI canvas rendering code,
so they too live in the "render/*" directory hierarchy.
I also know of a user that is working on a OpenGL renderer for fpGUI.
Since there are going to be changes that require adjustments anyway,
I wonder if it would make sense to just make agg_2D always require
the pixel format in the constructor:
constructor Agg2D.Construct_PF(pixfmt:define_pixfmt);
It seems the original intention of aggpas was to have this
flexibility but somewhere along the way things like rgba ended up
getting hard coded into it.
A very good point. I'll make a note to commit those changes too.
Better off to just fix it then fix any programs as needed instead of
having an even bigger and more confusing mess that no one will
remember why it's like that in 5 years.
Exactly!
Regards,
Graeme
--
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/
My public PGP key: http://tinyurl.com/graeme-pgp
_______________________________________________
fpc-pascal maillist - fpc-pascal@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
