Am 09.11.2018 um 03:13 schrieb Ryan Joseph: > > >> On Nov 9, 2018, at 4:28 AM, Florian Klämpfl <flor...@freepascal.org> wrote: >> >> I like the idea of const in generics, but it needs serious cleanup when it's >> working: >> - commit messages like "first commit" are useless > > Those are for github so I could share but I need to learn SVN (again) > eventually.
This does not prevent you from creating proper commits, especially as the patch series from github could be easily applied later on to fpc's main repository. > >> - the compiler contains already a type called tgenericdef > > I think I changed that name in the last commit. Btw I made all those types > because I didn’t want to populate the main types like ttypesym with extra > bytes but I don’t know what’s best practice in the codebase. Priority is: 1. maintainability 2. portability 3. speed Keep also ppu storing/loading in mind. _______________________________________________ fpc-pascal maillist - fpc-pascal@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal