> On Nov 10, 2018, at 7:16 PM, Florian Klämpfl <flor...@freepascal.org> wrote: > > This does not prevent you from creating proper commits, especially as the > patch series from github could be easily > applied later on to fpc's main repository.
I’ll assume these commits could be public some day then. I originally thought I would have to trash them all and start over for svn anyways. > >> >>> - the compiler contains already a type called tgenericdef >> >> I think I changed that name in the last commit. Btw I made all those types >> because I didn’t want to populate the main types like ttypesym with extra >> bytes but I don’t know what’s best practice in the codebase. > > Priority is: > 1. maintainability > 2. portability > 3. speed > > Keep also ppu storing/loading in mind. Thus far on the compiler I haven’t encountered PPU's at all so I just assumed they were part of the code generator and I didn’t need to worry about them. How are they relevant here? Honestly I barely know what the PPU’s are and how the compiler uses them. Regards, Ryan Joseph _______________________________________________ fpc-pascal maillist - fpc-pascal@lists.freepascal.org http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal