On Saturday,  3 July 1999 at  0:09:53 +0000, Ben Rosengart wrote:
> On Sat, 3 Jul 1999, Greg Lehey wrote:
>
>> I personally think that, in such a case, you'd be justified to commit
>> it as a temporary measure.  Due to the difference in time zones, this
>> has hit people while I've been asleep.  That doesn't mean the commit
>> would stay, of course, but at least it would save people unnecessary
>> pain.  Note, of course, that I have now committed the correct file,
>> which I had forgotten last night.
>>
>> What do you others think?
>
> Was the fix that wasn't yours correct? 

No.

> 'Cause I'd rather have code that doesn't compile than code that
> compiles but is subtly wrong.

Well, you can now have code that compiles and is correct :-)

Seriously, the only problem with Brian's fix was that it added a new
variable.  It would have made the stats list functions not work.  I
think that, for the period of time it would have been there, it would
have been the right thing to do: most people don't use Vinum, so the
breakage there is just a thorn in their side.  For those who do,
they'll notice the problem and report it.

Greg
--
See complete headers for address, home page and phone numbers
finger [EMAIL PROTECTED] for PGP public key


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to