On Mon, 18 Jan 1999, Mike Smith wrote: > > > So malloc() will generally not return NULL even in low memory > > > situations > > > unless the KVM map fills up, which isn't supposed to happen but can in > > > certain severe circumstances. Callers should therefore check for > > > NULL. > > > > why not just put it in a loop and block on lbolt? > > (or call panic) > > Because you shouldn't panic unless there's no alternative. Panicking > on resource starvation is just totally lame.
Ahem: uipc_mbuf.c: unmodified, readonly: line 268 of 945 [28%] panic("Out of mbuf clusters"); uipc_mbuf.c: unmodified, readonly: line 296 of 945 [31%] panic("Out of mbuf clusters"); And if the max number of mbuf clusters is{, to become} a sysctl, shouldn't these just be informative printf()s or something? > > -- > \\ Sometimes you're ahead, \\ Mike Smith > \\ sometimes you're behind. \\ m...@smith.net.au > \\ The race is long, and in the \\ msm...@freebsd.org > \\ end it's only with yourself. \\ msm...@cdrom.com > > > > To Unsubscribe: send mail to majord...@freebsd.org > with "unsubscribe freebsd-current" in the body of the message > Brian Feldman _ __ ___ ___ ___ gr...@unixhelp.org _ __ ___ | _ ) __| \ http://www.freebsd.org/ _ __ ___ ____ | _ \__ \ |) | FreeBSD: The Power to Serve! _ __ ___ ____ _____ |___/___/___/ To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message