On 20/11/2018 14:37, Ben Widawsky wrote: > On 18-11-20 11:28:56, Ben Widawsky wrote: >> On 18-11-20 14:09:08, Jung-uk Kim wrote: >>> On 18. 11. 20., Charlie Li wrote: >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] >>>> (0xfffff80003662300) [EmbeddedControl] (20181031/evregion-288) >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl >>>> (ID=3) has no handler (20181031/exfldio-428) >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution >>>> failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) >>>> >>> I am pretty sure r340644 caused the regression. >>> >>> https://svnweb.freebsd.org/changeset/base/340644 >>> >>> Jung-uk Kim >> >> Seems like a good bet. Could you please add the full dmesg as well as an ACPI >> dump and the output of `sysctl dev.acpi_ec.` Thanks. The full dmesg is flooded. sysctl dev.acpi_ec: dev.acpi_ec.0.%parent: acpi0 dev.acpi_ec.0.%pnpinfo: _HID=PNP0C09 _UID=0 dev.acpi_ec.0.%location: handle=\_SB_.PCI0.LPC_.EC__ dev.acpi_ec.0.%driver: acpi_ec dev.acpi_ec.0.%desc: Embedded Controller: GPE 0x25, ECDT dev.acpi_ec.%parent: > > Just for a quick eyeball, this looks suspicious. You could also try this: > I had to remove another line due to -Wunused-variable. In any case, the log spam continues unabated and battery status querying continues to fail.
Going to try backing out r340644 in my tree. -- Charlie Li Can't think of a witty .sigline today… (This email address is for mailing list use only; replace local-part with vishwin for off-list communication)
diff -r 531cf2dab058 sys/dev/acpica/acpi_ec.c
--- a/sys/dev/acpica/acpi_ec.c Mon Nov 19 17:31:36 2018 -0500
+++ b/sys/dev/acpica/acpi_ec.c Wed Nov 21 10:52:58 2018 -0500
@@ -338,7 +338,6 @@
ACPI_HANDLE h;
ACPI_OBJECT *obj;
ACPI_STATUS status;
- device_t peer;
char desc[64];
int ecdt;
int ret;
@@ -422,6 +421,7 @@
/* Store the values we got from the namespace for attach. */
acpi_set_private(dev, params);
+#if 0
/*
* Check for a duplicate probe. This can happen when a probe via ECDT
* succeeded already. If this is a duplicate, disable this device.
@@ -431,6 +431,7 @@
ret = 0;
else
device_disable(dev);
+#endif
if (buf.Pointer)
AcpiOsFree(buf.Pointer);
signature.asc
Description: OpenPGP digital signature
