On Thu, 2019-07-25 at 13:13 -0500, Larry Rosenman wrote: > On 07/25/2019 1:10 pm, Alan Somers wrote: > > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman <l...@freebsd.org> > > wrote: > > > > > > Um.... Who broke this? > > > > > > /usr/src/sys/sys/refcount.h:65:12: error: use of undeclared > > > identifier > > > 'false' > > > return (false); > > > ^ > > > [...] > > > > > "svn blame" suggests r350199 by kib. However, refcount.h should > > only > > be included if lsof defines _KERNEL, which normal programs > > shouldn't. > > So I think this should be considered a bug in lsof. > > -Alan > > > we *HAVE* to define _KERNEL, to get at the kernel structures.....
Then you have to follow the rules (from style(9))... If either <sys/types.h> or <sys/param.h> is needed, include it before other include files. (<sys/param.h> includes <sys/types.h>; do not include both.) Typically, if you're including anything from sys/ you'll need sys/types.h first. -- Ian _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
