Kris,

I guess once this is committed, the patch I sent you for ssh will no 
longer be necessary.

To the cc list: My patch just told ssh to 

  xstrdup(pw_class ? pw_class : "")

> On Sun, Sep 24, 2000 at 11:43:01PM +0900, Seigo Tanimura wrote:
> > As we are supposed to fill in all of the members in struct passwd
> > (like Solaris), _pw_passwd should have its initial value other than
> > zero.
> > 
> > static struct passwd _pw_passwd =
> > {
> >     "",
> >     "",
> >     (uid_t)0,       /* XXX Is zero appropriate? */
> >     (gid_t)0,
> >     (time_t)0,
> >     "",
> >     "",
> >     "",
> >     "",
> >     (time_t)0,
> >     0,
> > };
> 
> I agree -- it bit me while working on some additional nsswitch
> backends.  Using a pointer to an empty string would be more safe.  As
> to the XXX comment, those fields have been 0 forever, no point in
> changing them now.  Unless objections come up, I'll commit this change
> or something similar with the next nsswitch commit.
> 
> Thanks for the suggestion!
> -- 
> Jacques Vidrine / [EMAIL PROTECTED] / [EMAIL PROTECTED] / [EMAIL PROTECTED]

-- 
Brian <[EMAIL PROTECTED]>                        <brian@[uk.]FreeBSD.org>
      <http://www.Awfulhak.org>                   <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to