On Fri, Oct 27, 2000 at 06:11:49PM +0300, Ruslan Ermilov wrote:
> On Fri, Oct 27, 2000 at 07:34:06AM -0700, Mike Smith wrote:
> > > On Fri, Oct 27, 2000 at 09:49:57PM +1100, Bruce Evans wrote:
> > > [...]
> > > >
> > > > NetBSD supports the ntohl family on constants, but only on some arches
> > > > (at least in last year's version). It takes fancier macros to support
> > > > constants. This gives an excuse to change the inline functions back to
> > > > macros :-).
> > > >
> > > Cool! My upcoming byte-swapping changes to IPv4 code would benefit from
> > > having these macros. Could you please review the attached patch (it was
> > > obtained from NetBSD)?
> > ...
> > > +#ifdef __OPTIMIZE__
> >
> > Using macros does not "optimise" anything, and this is a very poor choice
> > of defines. __MACRO_ENDIAN_CONVERSIONS might be better.
> >
> Huh, you would not call this optimization?!
>
Just thought that you raised another issue here, the choice of __OPTIMIZE__.
If that's the case, it is the GCC's define used to indicate the optimizing
compilation:
# cpp -O -dM /dev/null
#define __FreeBSD__ 4
#define __FreeBSD_cc_version 410000
#define __i386__ 1
#define __i386 1
#define i386 1
#define __OPTIMIZE__ 1
#define __unix 1
#define __unix__ 1
#define __ELF__ 1
#define unix 1
--
Ruslan Ermilov Oracle Developer/DBA,
[EMAIL PROTECTED] Sunbay Software AG,
[EMAIL PROTECTED] FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
