https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268540
Alexander Leidinger <netch...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |netch...@freebsd.org
--- Comment #19 from Alexander Leidinger <netch...@freebsd.org> ---
I'm not tijl, but I'm the one who wrote (years ago) the base of the linux
userland stuff which we have today (which has a lot of good improvements since
then).
What I looked at:
- the Mk files
- if source rpms are in the distinfo
- if config files are "fall through to FreeBSD config where possible"
What I noticed:
- pulseaudio doesn't use the FreeBSD config, I assume due to the disable of
shm. I suggest a pkg-message to notify the user that the config is not
fall-through (and why).
- libtracker-sparql has no src rpm listed in the distinfo
- nspr has no src rpm listed
- libglvnd has etc config dirs instead of a fall through to FreeBSD, on
purpose or an oversight?
- ca-certificates: the etc part needs to be fall through, having the stock CAs
there in case the user has modified stuff in the corresponding FreeBSD side is
security relevant.
- nss: don't know what the etc part specifies, but maybe likewise to the
ca-certificates comment
- fontconfig: etc and var/db/fontconfig fall through is missing
- libusb: I'm surprised about
.if ${ARCH} == amd64 && ${FLAVOR:Mc7}
ONLY_FOR_ARCHS+= i386
I would have expected a +=i386 in the c7 case alone. Am I misunderstanding
something that this doesn't make sense to me?
- openal-soft: no fall through. I'm on the edge here. A part of me agrees to
no fall through, a part of me doesn't. Something like pulseaudio is sort of
mainstream and may already be installed on the FreeBSD side (= fall through),
openal doesn't look mainstream and a missing config may lead to a bad user
experience.
- dbus-libs and some others: PORTREVISION is set, for some of them I see a
correlation with the rpm name (some kind of package revision there too), but it
is handled inconsistently and will diverge in case some port stuff needs to be
fixed. If this is for your local install and it will go away on a version
increment: ignore this comment.
- linux-r19: the comment says it's centos
- vulkan: no fall through
- libvdpau: no fall through.
- r7-office + linux-chrome: I suggest to do a separate commit for this, not as
part of the r19 introduction into the ports tree.
Generic note: we don't install the corresponding FreeBSD port if we have a
config fall through. This only matters if the actual software is used instead
of simply part of the linux base. Personally I didn't care much about this
case, when I needed something I simply installed it, but maybe we want to
rethink what we do here (I do not consider this in-scope of this PR, I simply
mention it for completeness).
--
You are receiving this mail because:
You are the assignee for the bug.
