On Fri, Jul 27, 2001 at 09:44:12PM -0700, David O'Brien wrote:
> I'd like to apply this patch to pkg_add which reduces the amount of code
> the compiler generates, and improves the clarity of the code.
> 
> 1. s_strl* is obvious some form of "safe" strl{cpy,cat}.  But *WHAT*
>    does it make "safe"?  Isn't obvious w/o having to track down the
>    s_strl{cat,cpy} function definitions.
> 
> 2. The current code has more function call overhead than is needed.  And
>    it reduces the size of the basic block for the optimizer to work on.
>    It also potentially has cache miss penalties.

I now think these should be macros which do the if() test and the errx.

Kris

PGP signature

Reply via email to