From: "David O'Brien" <[EMAIL PROTECTED]>
Subject: [PATCH] reduce text(code) size and improve clarity of pkg_add
Date: Fri, 27 Jul 2001 21:44:12 -0700
> I'd like to apply this patch to pkg_add which reduces the amount of code
> the compiler generates, and improves the clarity of the code.
As the original author of this code, I'll just say that I favor
clarity over speed. As long as you can achieve reasonable security
with whatever approach is used, I vote for the shortest one which has
the least number of private or otherwise "lesser known" functions
since that also obscures clarity. Everybody knows [or should] what
strncpy() and friends do and the intention of code which uses them is
therefore pretty clear. If we're lacking the appropriate functions
for doing safe string copies (which I find hard to believe) then we
ought to be arguing for extending the appropriate base library, not
adding them as private functions to pkg_install. My two cents.
- Jordan
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message
