* Matthew Dillon <[EMAIL PROTECTED]> [020623 13:32] wrote: > :I'm pretty sure you only need to 'goto restart' if you call into > :maybe_resched() as someone else may have manipulated the queues. > : > :The 'restart' label is only in there for restarting in case one of > :the functions called may change the lists, if we restart _every_ > :time we'll traverse the same procs where p->p_wchan != ident over > :and over needlessly. > : > :-Alfred > > Look at the code carefully. It's *removing* the element from the list, > the conditionally restarting rather then removing the element from the ------^^^ then?? > list and unconditionally restarting. The only reason it works at all > is because sys/queue.h does not clear out the pointers in the node > that was just removed. The code is just plain wrong, though, because > the queue mechanisms make no such (documented) guarentee.
You're right, but other than await() why would a process find itself on a sleep queue if not in SSLEEP? -- -Alfred Perlstein [[EMAIL PROTECTED]] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message
