On Thu, Jan 23, 2003 at 08:47:06PM +0300, Yar Tikhiy wrote: > On Thu, Jan 23, 2003 at 03:47:49PM +0200, Peter Pentchev wrote: > > > > Attached is a patch to the libexec/ftpd source, which adds a new -P > > option taking an argument of either a numeric port number or a service > > name as described in the getaddrinfo(3) manual page. What do people > > think about adding this functionality? > > Peter, here is a bit reworked version of your patch. > Does it look reasonable?
Yes, this looks fine; the data connection port issue was brought up by Matthew Seaman in a private message to me, which I did not respond to immediately, because I wanted to feel the general thoughts on the subject. Now that you have incorporated it into your patch, it all sounds great :) I see that you have also changed my '.Nm' macro for the 'ftp' service to '.Dq'; that's fine too, I was in quite a bit of doubt myself over exactly which mdoc macro to use. The '.Nm' came from the telnet(1) manual page, but it did not look quite right to me. Thanks for your fast reaction :) I guess libexec/ftpd is your code, so it's your call to commit at will if nobody objects. G'luck, Peter -- Peter Pentchev [EMAIL PROTECTED] [EMAIL PROTECTED] PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 "yields falsehood, when appended to its quotation." yields falsehood, when appended to its quotation.
msg39380/pgp00000.pgp
Description: PGP signature
