Hi Rick,

On Mon, 12 Oct 2015, Rick Macklem wrote:

Christian Kratzer wrote:
Hi Rick,

there was also a second more recent crash in /var/crash

     Mon Oct 12 03:01:16 CEST 2015

     FreeBSD noc3.cksoft.de 10.2-STABLE FreeBSD 10.2-STABLE #2 r288980M: Sun
     Oct 11 08:37:40 CEST 2015
     c...@noc3.cksoft.de:/usr/obj/usr/src/sys/NOC  amd64

     panic: Assertion mtx_unowned(m) failed at
     /usr/src/sys/kern/kern_mutex.c:955

Oops, I screwed up. I should have looked at this panic assertion when you 
reported
it before. Ok, so if I understand the assertion correctly, it means that another
thread has the mutex locked. If this is correct, I'll have to take another look 
at
the code and figure out how to wait for these other threads to finish with the 
mutexes.

I do think the patch fixes the race I saw, but there must be other races in the 
code.

I'll take another look, but if anyone else is conversant with netsmb, feel free 
to
jump in, because it is all new to me.

Unfortunately, I won't have any way to do testing for the next month or so, so 
any
patches I do come up with will be "try this untested..".

thats no problem.

Just keep the patches coming when you have time and tell me when to reset back 
to stable,
current or whatever so we don't lose sync of the status.

As it looks like that the race happens on unmount I could try putting a sleep 
60 into the
script that does the "mount && rsycn && umount" magic just before the umount.  
That would
allow anything that it slow to go away to perhaps release the mutexes before 
the umount.

Not a real fix of course but might help to verify what's going on.

Greetings
Christian


--
Christian Kratzer                   CK Software GmbH
Email:   c...@cksoft.de               Wildberger Weg 24/2
Phone:   +49 7032 893 997 - 0       D-71126 Gaeufelden
Fax:     +49 7032 893 997 - 9       HRB 245288, Amtsgericht Stuttgart
Mobile:  +49 171 1947 843           Geschaeftsfuehrer: Christian Kratzer
Web:     http://www.cksoft.de/
_______________________________________________
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

Reply via email to