On 24 Mar 2016, at 23:54, Dimitry Andric <d...@freebsd.org> wrote: > > On 24 Mar 2016, at 23:51, Bryan Drewery <bdrew...@freebsd.org> wrote: ... >> It fails without -std=c++11 (there's more discussion in that link and in >> PR 205453). > > Yeah, I also commented on PR 205453 in the past, but I still don't > understand where the external gcc gets its _Static_assert macro from. > Or whether it gets it at all. Maybe we should place a hack for this in > sys/cdefs.h? We shouldn't litter contrib code with #ifdef GCC_VERSION > blocks.
Hm, hacking around in cdefs.h also doesn't really help, because gcc refuses to recognize either _Static_assert or static_assert when it's not in C++11 mode. Reading back https://reviews.freebsd.org/D1390, I see that I originally wanted to avoid building libcxxrt with -std=c++11. This was so you could even build it with gcc 4.2.1 from base. However, it really doesn't make much sense to do so, and upstream libcxxrt simply uses static_assert directly, and requires -std=c++11. I will update the libcxxrt build to do so, probably tomorrow. -Dimitry
signature.asc
Description: Message signed with OpenPGP using GPGMail
