URL:
  <http://gna.org/patch/?6885>

                 Summary: Remove fc_config.h include from name_translation.h
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sun 31 Jan 2016 05:02:29 PM EET
                Category: general
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.6.0, 3.0.0

    _______________________________________________________

Details:

Include for fc_config.h was added to name_translation.h in r20375 / bug #18864
with explanation:

"fix usage of fcintl.h
 ...
 - must be in name_translation.h (inline functions)"

I assume that the reason fc_config.h was added there (and fcintl.h include
mentioned in the explanation not touched at all) was that fcintl.h did not
work without fc_config.h being included. Now it does, by properly including
freeciv_config.h itself.

So getting rid of that one fc_config.h include in a public header file that
should not include it seems to be as simple as removing it. Attached patch
does that.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 31 Jan 2016 05:02:29 PM EET  Name:
NameTranslationFcConfigInclRm.patch  Size: 417B   By: cazfi

<http://gna.org/patch/download.php?file_id=26545>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?6885>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to