On 15.08.2013 10:40, Michael T. Pope wrote: > On Sun, 11 Aug 2013 15:54:29 +0200 > Michael Vehrs<michael.bursc...@gmx.de> wrote: > >> Update: I have fixed all test failures except for six that occur only >> when running all tests, but not when running the test suite >> individually. I conclude that some tests must be messing around with the >> specification, causing the static role fields to change. >> > Its not just the test suite. Currently strange things happen anyway > (because we often read the spec twice, see "updateGame"). ISTM that the > static roles are pretty odd things now. They might have made sense > before when there was a finite hardcoded set of them, but now they are > extendable we should be looking them up out of the spec like we do with > other spec types. > > Of course, saying that makes me responsible for fixing all the static role > usage. > > Cheers, > Mike Pope
Alright. Let's get rid of them. I suggest we split the work along packages. A quick grep shows that there are about 150 call sites, about half of them in the model package. Shall I tackle the model? Regards Michael ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
