Hi guys,
I patched up the horses bug (#2684).

Philosophy of the bugfix:
The indians were gaining horses out of nowhere, because
ServerIndianSettlement treated them like any other resource. This led into
gaining even 10-15 horses each turn.
Now horses are skipped in this step and bred with respect to the max 2 per
turn policy, which was already implemented.
Because of the correction, the indians would be in great disadvantage since
they would need to buy a pair of horses first, then the breeding would kick
in.
Players could abuse this behavior, forcing indians to exist with no horses
at all. To mitigate the situation, I modified server controller the way
that every time there is FIRST contact of European
nation with natives, the natives gain two horses in their capital. Then the
breeding starts doing its job like I previously explained.

Some tests showed the implementation is behaving in a good way - I met
first indian nation in turn 3 and first mounted unit appeared approx. in
turn 26. After turn 35 there were just 5 mounted units all over the world.
Examining the save games showed that horses gradually spread througout the
map as the nations were meeting each other, which was exactly what I
intended.

Patchfile attached.

Regards,
Petr


2014-04-08 12:30 GMT+02:00 Michael T. Pope <mp...@computer.org>:

> On Sun, 6 Apr 2014 09:59:46 +0200
> Petr Fišer <pries...@gmail.com> wrote:
> > I'm slowly moving forward. Problem is, I currently have a lot of work at
> > school, so not much free time.
>
> That is only too familiar a situation.
>
> > I should complete the fix in week or two (I hope).
>
> That would be good.  There are about four blocker bugs (including this
> one) left before we can consider a release, but at the current rate of
> progress I doubt we will be ready until May at the earliest.
>
> Cheers,
> Mike Pope
>

Attachment: bugfix-2684.patch
Description: Binary data

------------------------------------------------------------------------------
Put Bad Developers to Shame
Dominate Development with Jenkins Continuous Integration
Continuously Automate Build, Test & Deployment 
Start a new project now. Try Jenkins in the cloud.
http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to