On 14-07-11 05:22 PM, Michael T. Pope wrote: > The "artillery in the open" penalty will apply, but that should be visible > in the pre-combat dialog.
The documentation says there should be no penalty for being in the open when attacking a colony (and possibly a native settlement - that's unclear). Attacking an unit in the open and defending in the open in all cases are supposed to get the penalty, of course. I dug up an autosave from the game where I noticed this. Adding some logging to calculateCombatOdds() shows that the artillery is being calculated at strength 2.625 and the defender (king's cavalry) at 39.375 which gives win odds of 6.25%. That means the artillery is being penalized for being in the open attacking a colony, directly at odds with the documentation. (They're useless for offense if that is supposed to happen.) I notice that the odds are *slightly* better than I recall but not appreciably so - probably recalling the odds using a damaged artillery, which should be correspondingly lower. The pre-combat report specifies a base offense of 7, a bonus under the colony name of 100% and the attack bonus of 50% for a total of 21. That is clearly not 2.625 but it does clearly match the documentation. (If an offense power of 21 is used, that gives odds of just under 35%.) So we have the pre-combat report showing a different set of modifiers than the actual combat uses. This is unrelated, but I also noticed, when adding some logging to getDefencePower() that it is being called continually for no apparent reason while the game is waiting for input from me. Nothing should be happening in the background. It's even called during a refresh when moving a window across the front of the game window. Or even moving the mouse pointer, and on units that aren't actually relevant to anything. I'm thinking that may be an efficiency issue. I wouldn't expect those to be called except when combat is going to happen. > When fighting the REF at a settlement, the owner of the settlement now > should get the "popular support" bonus, equal to the colony independence > support (reversed for the REF). This may be broken, or you may > have been attacking a settlement with 0% support for liberty. This would > make things harder. > All the data is there in the log file, including as you have noticed, the > expected chance of winning. If it is as low as 4% then 75 losses is > vaguely credible. However you are right to raise this for investigation. > >> On an only tangentially related note, it occurs to me that I really >> should see if I can grok the code and contribute more substantially. > > SimpleCombatModel.java is the main place to look. However I fear it is > misnamed:-). It does now contain more comments than when I first started > working on it though. > > Cheers, > Mike Pope > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > Freecol-developers mailing list > Freecol-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/freecol-developers > ------------------------------------------------------------------------------ _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
