On Fri, 18 Sep 2015 21:28:46 +0200 win...@genial.ms wrote: > I experimented a bit with replacing FreeColDialog cause of the problems > with JDialog. > I used JOptionPane.showInternalConfirmDialog and for me the dialog for > quitting the game from main menu actually did work and was correctly > behaving modal (prevented clicking the main menu while open).
Quite so. The modal case is the one that works:-). > There just turned out to be some problem with the look and feel, the > buttons are showing class name+hash number. > It would also be difficult to get rid of the ugly green border and > title bar, as these methods are all-in-one affairs and difficult to > replace, maybe the look-and-feel can be set to allow this? I do not know. I have kicked the L&F a few times but do not pretend to understand it. > As for the non-modal dialogs, I wonder why the DialogCallback is > creating threads and polling every half second? Shouldn't it be enough > to set a listener for the dialog closing? IIRC there were intermittent hangs and/or missing calls (particularly when several dialogs came up together) --- it was just not reliable. Hopefully, again, this was just due to Java bugs at the time. In the end I got exasperated and did an explicit implementation of the required concurrency. > Not sure if its worth trying to change this or better to skip that and > only work on replacing those non-modal dialogs with panels. If those non-modal dialogs become panels, surely that gets rid of all the uses of DialogCallback anyway? No sense in fixing things twice. Cheers, Mike Pope
pgpNVb7RCJU7U.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
