On Tue, 6 Dec 2016 09:50:11 -0500 Dong Kim <dong...@andrew.cmu.edu> wrote: > Sounds awesome, thanks for all your help! It was a great experience > overall.
Not entirely. I just grabbed the merge, and it is very hard for me to work out what you have done because of all the code reformatting. In particular, there are TABs everywhere, which we explicitly ask *not* to be used in FreeCol code contributions. Look at AbstractGoodsLabel to see what I mean --- AFAICT there you have added a new field and setter/getter methods for it, but "git diff" shows almost all of the file is changed! I strongly encourage you to put in another merge request that contains *only* what needs to change to implement the features. As things stand I can not merge without a lot of extra tedious work. Cheers, Mike Pope
pgp89uBHQjk5Q.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/xeonphi
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
