Hi, > Gesendet: Sonntag, 12. Februar 2017 um 02:32 Uhr > Von: "Michael T. Pope" <mp...@computer.org> > An: win...@genial.ms > Cc: "FreeCol Developers" <freecol-developers@lists.sourceforge.net> > Betreff: Re: [Freecol-developers] River styles > > Will test.
Nice. > I am not sure either now. The change to river styles was not my code. > Later when trying to fix the broken maps I recall being deeply confused > about what used to be valid, so I tried to be generous in what we read > (so potentially including nonexisting cases), and conservative in what we > wrote. I remember getting some NPE when I tried removing a null check in the display code a few months ago, but that might have been caused by the checking having replaced 0000 with null. I guess its safer to keep a null check. > > In my own save I also found a few null roads were duplicated, is that a bug? > > I think so, but not a serious one. > > > I only saw that when checking the output from the updated readAttributes > > for correctness in the logfile. It looks like other parts of the game > > might not be accessing the duplicate, as it keeps the null style and gets > > resaved that way. I'll attach the save and log file. > > Examples you can search for: > > tile:3139 > > tile:9240 > > Which save game? I do not see any duplicates in the attached one for > tile:3139. I was going from the log file I had attached, where these tiles appeared to be read in twice. The savegame name should be in the log and the same I had attached, 14e3a40e_Niederländisch_1508.fsg - is it not? I had unpacked the save, looked at and searched the xml, then thought I had seen 2 road improvements for that tile number inside it (not the tile itself, the snippets were for searching the log but have the tile number for the save), but my eyes may have been confused by the huge pile of run-together characters. > > Btw., I could not get the integrity checker to output something useful: > > $ ant validate-savegame > > -Dsavegame=../../freecol/save/14e3a40e_Niederländisch_1508.fsg > > OK, that one is validating the game against the schema. I will look into > what is happening there. However that is a different thing from the > integrity checker, as in the checkIntegrity stuff in the code, which I get > to with the --check-savegame argument on the FreeCol command line. Ah yes, that makes sense. Greetings, wintertime ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
